Skip to content

[Dynamic Dashboard] Code cleanup #11457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
May 8, 2024
Merged

[Dynamic Dashboard] Code cleanup #11457

merged 21 commits into from
May 8, 2024

Conversation

hichamboushaba
Copy link
Member

@hichamboushaba hichamboushaba commented May 6, 2024 •
edited
Loading

Closes: #11455

Description

This PR cleans up the code of the old MyStoreFragment screen and its related dependencies.

Testing instructions

Code review and smoke test the dynamic dashboard screen.

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@dangermattic
Copy link
Collaborator

dangermattic commented May 6, 2024 •
edited
Loading

3 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ This PR is assigned to the milestone 18.6. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.
1 Message
📖

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

@hichamboushaba hichamboushaba added type: task An internally driven task. feature: dashboard Related to home screen project labels May 6, 2024
@hichamboushaba hichamboushaba added this to the 18.6 milestone May 6, 2024
@hichamboushaba hichamboushaba added the category: tracks Related to analytics, including Tracks Events. label May 6, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 6, 2024 •
edited
Loading

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commite448494
Direct Downloadwoocommerce-prototype-build-pr11457-e448494.apk

@hichamboushaba hichamboushaba requested a review from 0nko May 7, 2024 12:20
@hichamboushaba hichamboushaba marked this pull request as ready for review May 7, 2024 12:20
@hichamboushaba hichamboushaba requested a review from a team as a code owner May 7, 2024 12:20
@hichamboushaba hichamboushaba added the status: do not merge Dependent on another PR, ready for review but not ready for merge. label May 7, 2024
Base automatically changed from dynamic-dashboard/ui-tests to trunk May 7, 2024 14:22
@hichamboushaba hichamboushaba removed the status: do not merge Dependent on another PR, ready for review but not ready for merge. label May 7, 2024
@hichamboushaba
Merge branch 'trunk' into dynamic-dashboard/code-cleanup
d0a6c0b 
# Conflicts:
#	WooCommerce/src/main/kotlin/com/woocommerce/android/ui/dashboard/blaze/DashboardBlazeViewModel.kt
@hichamboushaba
Fix detekt issues
d1d99a5
@hichamboushaba hichamboushaba force-pushed the dynamic-dashboard/code-cleanup branch from 8bedf65 to d1d99a5 Compare May 8, 2024 09:20
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 36.70886% with 50 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (trunk@9bbf58a). Click here to learn what that means.
Report is 29 commits behind head on trunk.

Files Patch % Lines
...e/android/ui/dashboard/blaze/DashboardBlazeCard.kt 0.00% 24 Missing ⚠️
...roid/ui/dashboard/blaze/DashboardBlazeViewModel.kt 0.00% 20 Missing ⚠️
...merce/android/ui/dashboard/data/StatsRepository.kt 92.00% 1 Missing and 1 partial ⚠️
...on/payment/BlazeCampaignPaymentSummaryViewModel.kt 50.00% 1 Missing ⚠️
...com/woocommerce/android/ui/jitm/JitmUtmProvider.kt 0.00% 1 Missing ⚠️
...mmerce/android/ui/main/BottomNavigationPosition.kt 0.00% 1 Missing ⚠️
...oocommerce/android/ui/products/ProductNavigator.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##             trunk   #11457   +/-   ##
========================================
  Coverage         ?   40.85%           
  Complexity       ?     5142           
========================================
  Files            ?     1057           
  Lines            ?    61818           
  Branches         ?     8422           
========================================
  Hits             ?    25256           
  Misses           ?    34295           
  Partials         ?     2267

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0nko 0nko self-assigned this May 8, 2024
0nko
0nko approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@0nko 0nko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🗑️

@0nko 0nko merged commit 5c1101d into trunk May 8, 2024
3 checks passed
@0nko 0nko deleted the dynamic-dashboard/code-cleanup branch May 8, 2024 21:57
@sentry-io Sentry.io
Copy link

sentry-io bot commented May 10, 2024 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0nko 0nko 0nko approved these changes

Assignees

@0nko 0nko

Labels
category: tracks Related to analytics, including Tracks Events. feature: dashboard Related to home screen project type: task An internally driven task.
Projects
None yet
Milestone
18.6
Development

Successfully merging this pull request may close these issues.

[Dynamic Dashboard] Code cleanup
5 participants
@hichamboushaba @dangermattic @wpmobilebot @codecov-commenter @0nko